Eagerly drop local scope in iteration #9838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Apr 11, 2018
| auto &t = scope->FindVar(kLocalExecScopeName) | ||
| ->Get<Scope *>() | ||
| ->FindVar(var_name) | ||
| ->Get<framework::LoDTensor>(); |
There was a problem hiding this comment.
Is this used to fetch the variable in the local scope?
| // Create local scopes. | ||
| for (auto &scope : member_->local_scopes_) { | ||
| Scope &local_scope = scope->NewScope(); | ||
| *scope->Var(details::kLocalExecScopeName)->GetMutable<Scope *>() = |
There was a problem hiding this comment.
What is usefule of scope->Var(details::kLocalExecScopeName) ? Please add comments.
There was a problem hiding this comment.
Currently, all non-persistable variables will be in the 'sub-scope of local scope'. The sub-scope is created before batch training and deleted after batch training.
… feature/drop_internal_scope_time_by_time
… feature/drop_internal_scope_time_by_time
qingqing01
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.