Added support for dim equals 2 in activation functions #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Apr 6, 2018
| auto dst_memory = mkldnn::memory({data_md, mkldnn_engine}, (void *)dst_data); | ||
| auto src_memory = | ||
| mkldnn::memory({data_md, mkldnn_engine}, | ||
| static_cast<void *>(const_cast<float *>(src_data))); |
There was a problem hiding this comment.
I see that we need const_cast here because we made the type of src_data const auto* in L37. Therefore, I think that instead of removing the const decorator here, we should remove the const from the definition in L37. Am I right?
The change in my mind is something like the following:
-
in L37, instead of
const auto *src_data = src->template data<T>();
we should have
auto *src_data = src->template data<T>();
-
Here, we could have
mkldnn::memory src_mem = mkldnn::memory({data_md, mkldnn_engine}, static_cast<void*>(src_data));
| auto src_memory = | ||
| mkldnn::memory({data_md, mkldnn_engine}, | ||
| static_cast<void *>(const_cast<float *>(src_data))); | ||
| auto dst_memory = |
There was a problem hiding this comment.
The type auto here is a little misleading. We are following Google C++ style in PaddlePaddle, so I'd thought that mkldnn::memory is a function, whose type is unknown until we check the documentation. This made me confused with that exact type auto is. How about
mkldnn::memory dst_memory = mkldnn::memory(...)
wangkuiyi
approved these changes
Apr 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important for RNN Search