Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sphinx version is specified as 1.5.6 in the Dockerfile #9093

Merged
merged 3 commits into from
Mar 15, 2018

Conversation

weixing02
Copy link
Collaborator

fix #9006

pip install -U docopt PyYAML sphinx && \
pip install -U sphinx-rtd-theme==0.1.9 recommonmark
pip install -U docopt PyYAML sphinx==1.5.6 && \
pip install sphinx-rtd-theme==0.1.9 recommonmark
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

59行的-U为什么要去掉呢,可以加个注释说明一下么?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 因为pip install -U sphinx-rtd-theme的-U选项会导致已经安装的sphinx(1.5.6)更新至sphinx最新版本(目前是1.7.1),这会导致文档编译失败

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks very much!

@ranqiu92 ranqiu92 merged commit 3ff649e into PaddlePaddle:develop Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception occurred when constructing documentation
3 participants