Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CPP Data Feeding design document #9033

Merged

Conversation

abhinavarora
Copy link
Contributor

No description provided.

Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@abhinavarora abhinavarora merged commit 2807896 into PaddlePaddle:develop Mar 13, 2018
@abhinavarora abhinavarora deleted the fix_cpp_data_feeding branch March 13, 2018 22:39
@JiayiFeng
Copy link
Collaborator

Thank you so much @abhinavarora ! We have just expanded the design of c++ readers and now I'm updating the design doc. After I finish that, could you please help us review it again? Thanks!

@abhinavarora
Copy link
Contributor Author

@JiayiFeng Please feel free to send me the review. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants