Receive from closed channel #8175
Conversation
|
@kavyasrinet I am afraid that I will be at the meeting for the whole night, so might not have time to polish this PR, which was originally created only for your reference. Please feel free to commit to my branch of this PR to fix the CI problems. Thanks! |
|
Sure, will do. |
… receive_from_closed_channel
kavyasrinet
dismissed stale reviews from abhinavarora and themself
via
c67c424
paddle/framework/channel_test.cc
Outdated
| EXPECT_EQ(ch->Send(&i), true); // sending should not block | ||
| } | ||
|
|
||
| int out; |
paddle/framework/channel_test.cc
Outdated
| @@ -119,6 +150,7 @@ TEST(Channel, BufferedChannelCloseUnblocksReceiversTest) { | |||
| int data; | |||
| // All reads should return false | |||
| EXPECT_EQ(ch->Receive(&data), false); | |||
| EXPECT_EQ(data, 0); | |||
There was a problem hiding this comment.
I do not think the data should be zero when the channel was closed. If the element of channel is Tensor* and the channel has been closed, what will the data be after ch->Receive(&data)
There was a problem hiding this comment.
it should be the zero value of that return type, as mentioned here: https://dave.cheney.net/2014/03/19/channel-axioms
Here are the zero values: https://golang.org/ref/spec#The_zero_value
For now I have removed this in my current commit, but once we decide we can introduce that behavior again
There was a problem hiding this comment.
The problem here is that C++ syntax doesn't define zero value of all types like Go does. So, basically, we have no idea how to write a C++ code snippet to clear the value of any data type to zero.
… receive_from_closed_channel
|
|
||
| for (size_t i = 0; i < buffer_size; ++i) { | ||
| EXPECT_EQ(ch->Receive(&out), | ||
| false); // after receiving residual values, return zeros. |
There was a problem hiding this comment.
This annotation should be removed or changed.
// after receiving residual values, return zeros.
No description provided.