New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close buffered channel should unblock the blocked senders and receivers #8109

Merged

abhinavarora merged 1 commit into PaddlePaddle:develop from abhinavarora:close_test_buffered

Feb 4, 2018

Contributor

abhinavarora commented Feb 3, 2018

This PR adds the following:

Unit Test for checking that closing a channel unblocks all blocked senders and receivers.
Adds asserts in unit test for the boolean value returned by Send and Recv as per the latest PR by @chengduoZH Refine buffer channel #8098


          Close buffered channel should unblock the blocked senders and receivers

0a0a635

abhinavarora self-assigned this

abhinavarora requested review from wangkuiyi, kavyasrinet and chengduoZH

February 3, 2018 16:40

abhinavarora mentioned this pull request

Add Unit Tests for Buffered and Unbuffered Channels #8066

Closed

11 tasks

chengduoZH approved these changes

View reviewed changes

Contributor

chengduoZH left a comment

LGTM

abhinavarora merged commit 1d2dd9c into PaddlePaddle:develop

abhinavarora deleted the close_test_buffered branch

February 4, 2018 18:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet