Enhance distributed train performance #7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… distributed_split_selectedrows
gongweibao
reviewed
Jan 18, 2018
| // Get from multiple trainers, we don't care about the order in which | ||
| // the gradients arrives, just add suffix 0~n and merge the gradient. | ||
| rpc_service_->SetCond(0); | ||
| for (size_t i = 0; i < barrier_size; ++i) { |
There was a problem hiding this comment.
- 这一块代码太长了， 导致main loop比较复杂，容易出错。建议改成单独的一个函数。
… distributed_split_selectedrows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7607