-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fix and enhancement for lstm_unit python wrapper. #7157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Looks good. Just a minor clarification: Since, we aren't dealing with the W_{xc} c_{t-1} (where x = i and o), the current implementation is a minor variant (with no peephole connections) of the more general LSTM right?
@sidgoyal78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oops, as you might have seen already, i think the build failed. |
Thanks. An random failure, will restart CI ASAP. |
@pkuyym : Actually, it is not random. I think this line needs to be corrected:https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/tests/test_layers.py?utf8=%E2%9C%93#L180 and L181 |
No worries, I think I should have also thought of that while reviewing. So no problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Resolves #7156