Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update support new device docs #6963

Merged
merged 3 commits into from
Dec 25, 2017
Merged

update support new device docs #6963

merged 3 commits into from
Dec 25, 2017

Conversation

QiJune
Copy link
Member

@QiJune QiJune commented Dec 25, 2017

Fix #6962

@dzhwinter dzhwinter mentioned this pull request Dec 25, 2017
Closed
26 tasks
abhinavarora
abhinavarora suggested changes Dec 25, 2017
View reviewed changes
doc/design/support_new_device.md Outdated

#### Place
Fluid uses class [Place](https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/platform/place.h#L55) to represent different devices and computing libraries. There are inheritance relationships between different kinds of `Place`.
Fluid uses class [Place](https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/platform/place.h#L55) to represent the device memory where data is locating. If we add another device, we have to add corresponding `DevicePlace`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where data is locating -> where data is located

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

abhinavarora
abhinavarora reviewed Dec 25, 2017
View reviewed changes
doc/design/support_new_device.md Outdated
@@ -106,7 +107,7 @@ template <typename Place>
size_t Used(Place place);
```

To implementing these interfaces, we have to implement MemoryAllocator for different Devices
To implementing these interfaces, we have to implement MemoryAllocator for different Devices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementing -> implement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

abhinavarora
abhinavarora approved these changes Dec 25, 2017
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhinavarora abhinavarora merged commit ea5d6ea into PaddlePaddle:develop Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavarora abhinavarora abhinavarora approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QiJune @abhinavarora