add design doc on keys of operaror kernel type #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
requested review from
reyoung,
jacquesqiao,
dzhwinter,
tensor-tang and
tonyyang-svail
reyoung
previously approved these changes
Dec 21, 2017
jacquesqiao
reviewed
Dec 21, 2017
doc/design/operator_kernel_type.md
Outdated
| @@ -0,0 +1,91 @@ | |||
| # Design Doc: The Keys of Operator Kernel Type | |||
| ## Problem | |||
| An operator can have different kernel implementations, and each operator will have map to store the related kernels. Fluid uses `OpKernelType` as a key to identify a unique Kernel. Before an operator runs, an certain kernel must be choose by a key of `OpKernelType`. Currently, `OpKernelType` is defined as follows: | |||
There was a problem hiding this comment.
have map
have a map<KernelType, KernelImpl> ?
jacquesqiao
reviewed
Dec 21, 2017
doc/design/operator_kernel_type.md
Outdated
|
|
||
| ### Library | ||
|
|
||
| An operator kernel is usually implemented based on some library. `Library` is defined as a enum variable: |
There was a problem hiding this comment.
some library
some libraries
tensor-tang
approved these changes
Dec 21, 2017
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6781