new backward #6741
Merged
new backward #6741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
reviewed
Dec 26, 2017
python/paddle/v2/fluid/backward.py
Outdated
| return name + core.grad_var_suffix() | ||
|
|
||
|
|
||
| def _append_backward_ops_(target, |
There was a problem hiding this comment.
This function is so long to read.
There was a problem hiding this comment.
Yes. It's only a draft. I'm refactoring it.
… dev_new_backward
|
Does this mean that the previous append_backward implemented in C++ is no longer needed? |
|
Sorry for the delay in reply. Yes, the code in C++ is no longer needed. The purpose of this refactor is making backward supporting callback functions, which is required by error clip and gradient reduce in distributed training. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6600