Add python wrapper for lstm unit op. #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add some explanation that we need to add fc before lstm_unit op |
jacquesqiao
reviewed
Dec 18, 2017
| """ | ||
| helper = LayerHelper('lstm_unit', **locals()) | ||
|
|
||
| if len(x_t.shape) != 2: |
There was a problem hiding this comment.
should be removed, this will be check by infershape
There was a problem hiding this comment.
please remove all the shape check, if need, can add into infershape of operators.
There was a problem hiding this comment.
To make the exception more accurate, I think shape checking is also necessary here.
jacquesqiao
reviewed
Dec 18, 2017
| def lstm_unit(x_t, | ||
| hidden_t_prev, | ||
| cell_t_prev, | ||
| forget_bias=0.0, |
There was a problem hiding this comment.
add ParamAttr for fc's weight and bias
|
please fix conflict |
pkuyym
force-pushed
the
fix-6581
branch
3 times, most recently
from
518c43e to
164271e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6581.