Reduce memory usage in conv layer and RoI layer for mobile inference. #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedaoyuan
requested changes
Dec 15, 2017
paddle/function/GemmConvOp.cpp
Outdated
| @@ -233,6 +233,11 @@ class GemmConvGradInputFunction : public ConvFunctionBase { | |||
| inputGrad += inputChannels * inputHeight * inputWidth; | |||
| outputGrad += outputChannels * outputHeight * outputWidth; | |||
| } | |||
| #ifdef PADDLE_MOBILE_INFERENCE | |||
There was a problem hiding this comment.
Should fix GemmConvFunction not GemmConvGradInputFunction.
There was a problem hiding this comment.
Oh... I'm sorry. I'll fix it :)
hedaoyuan
approved these changes
Dec 15, 2017
hedaoyuan
reviewed
Dec 15, 2017
| @@ -126,6 +126,11 @@ class GemmConvFunction : public ConvFunctionBase { | |||
| inputData += inputChannels * inputHeight * inputWidth; | |||
| outputData += outputChannels * outputHeight * outputWidth; | |||
| } | |||
| #ifdef PADDLE_MOBILE_INFERENCE | |||
| if (Device == DEVICE_TYPE_CPU) { | |||
| delete memory_; | |||
There was a problem hiding this comment.
Need to use reset to release memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6658
Fix #6657