Remove main_program and startup_program as the paramter of layer function
#6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
changed the title
main_program and startup_program as the paramter of layer function
JiayiFeng
reviewed
Dec 18, 2017
| @@ -165,28 +156,23 @@ def __init__(self, | |||
| label=label, | |||
| chunk_scheme=chunk_scheme, | |||
| num_chunk_types=num_chunk_types, | |||
| excluded_chunk_types=excluded_chunk_types, | |||
| **kwargs) | |||
| excluded_chunk_types=excluded_chunk_types, ) | |||
There was a problem hiding this comment.
The line 153:
kwargs = {'main_program': main_program}should also be removed. I can not comment on unchanged line so I leave it here.
JiayiFeng
reviewed
Dec 18, 2017
python/paddle/v2/fluid/evaluator.py
Outdated
| layers.sums( | ||
| input=[self.num_infer_chunks, num_infer_chunks], | ||
| out=self.num_infer_chunks, | ||
| **kwargs) | ||
| out=self.num_infer_chunks, ) |
JiayiFeng
reviewed
Dec 18, 2017
| return default_main_program() | ||
| else: | ||
| return prog | ||
| return default_main_program() |
There was a problem hiding this comment.
As we can change the default program, I think it's improper to keep calling it default.
There was a problem hiding this comment.
maybe just main_program() is cool. It could be done in the following PR
JiayiFeng
reviewed
Dec 18, 2017
| avg_cost = layers.mean(x=cost) | ||
|
|
||
| sgd_optimizer = optimizer.SGDOptimizer(learning_rate=0.001) | ||
| sgd_optimizer.minimize(avg_cost, init_program) |
There was a problem hiding this comment.
Do we still need this init_program?
There was a problem hiding this comment.
We can remove init_program of optimizers in the following PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6458