Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typing][A-22,A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py #65460

Merged
merged 5 commits into from
Jun 28, 2024
Merged

[Typing][A-22,A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py #65460

merged 5 commits into from
Jun 28, 2024

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Jun 25, 2024 •
edited by SigureMo
Loading

PR Category

User Experience

PR Types

Improvements

Description

Add type annotations for `paddle/nn/{layer, functional}/pooling.py

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 25, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 25, 2024
@SigureMo SigureMo changed the title [Typing][A-21, A-63] Add type annotations for `paddle/nn/{layer, func… [Typing][A-21, A-63] Add type annotations for paddle/nn/{layer, functional}/pooling.py Jun 25, 2024
@SigureMo SigureMo mentioned this pull request Jun 25, 2024
Merged
SigureMo
SigureMo reviewed Jun 25, 2024
View reviewed changes
python/paddle/nn/functional/pooling.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/pooling.py Outdated Show resolved Hide resolved
@SigureMo SigureMo mentioned this pull request Jun 25, 2024
Closed
@SigureMo SigureMo changed the title [Typing][A-21, A-63] Add type annotations for paddle/nn/{layer, functional}/pooling.py [Typing][A-21, A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py Jun 26, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2024
@Asthestarsfalll Asthestarsfalll changed the title [Typing][A-21, A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py [Typing][A-22, A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py Jun 26, 2024
@megemini
Copy link
Contributor

@Asthestarsfalll 先等一下 #65197 吧 ～ 在那边把 _PaddingSizeMode: TypeAlias = Literal['valid', 'same', 'VALID', 'SAME'] 统一放到 common 里面 ～ 🙏

@SigureMo SigureMo changed the title [Typing][A-22, A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py [Typing][A-22,A-63] Add type annotations for paddle/nn/{layer,functional}/pooling.py Jun 27, 2024
@SigureMo
Copy link
Member

这个 PR 可以推进下了～

@Asthestarsfalll @megemini
Update python/paddle/nn/functional/pooling.py
1862308 
Co-authored-by: megemini <megemini@outlook.com>
SigureMo
SigureMo approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 474a079 into PaddlePaddle:develop Jun 28, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megemini megemini megemini left review comments

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asthestarsfalll @megemini @SigureMo @luotao1