Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConvTransProjection support for dilation #6188

Merged
merged 2 commits into from
Dec 7, 2017
Merged

Make ConvTransProjection support for dilation #6188

merged 2 commits into from
Dec 7, 2017

Conversation

wanghaoshuang
Copy link
Contributor

@wanghaoshuang wanghaoshuang commented Dec 2, 2017 •
edited
Loading

  1. Make ConvTransProjection support for dilation
  2. Fix wrong output size config in Projection.conv unitest while isDeconv=true

fix #6187 #6121

@wanghaoshuang
Fix ConvTransProjection bug.
b25ee3a 
1. Make ConvTransProjection support for dilation
2. Fix err config in Projection.conv unitest while deConv=true
@wanghaoshuang wanghaoshuang changed the title Fix ConvTransProjection bug. Make ConvTransProjection support for dilation Dec 2, 2017
tonyyang-svail
tonyyang-svail reviewed Dec 4, 2017
View reviewed changes
paddle/gserver/tests/test_LayerGrad.cpp Outdated
/// test ConvTransProjection
testProjectionConv(1, true);
testProjectionConv(3, true);
// testProjectionConv(3, true);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the current code pass the commented tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I forgot to uncomment the tests.
Current code passed the commented tests.

tonyyang-svail
tonyyang-svail approved these changes Dec 6, 2017
View reviewed changes
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. For the record, could you specify your test environment? Since our CI environment will always set dilation to 1.

@wanghaoshuang wanghaoshuang merged commit e09e21b into PaddlePaddle:develop Dec 7, 2017
@wanghaoshuang wanghaoshuang deleted the conv_fix branch December 7, 2017 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyyang-svail tonyyang-svail tonyyang-svail approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ConvTransProjection support for dilation.
2 participants
@wanghaoshuang @tonyyang-svail