[PIR & Inference] Refactor fused_weight_only_linear_pass #59792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
✅ This PR's description meets the template requirements! |
MARD1NO
approved these changes
Dec 8, 2023
yuanlehome
previously approved these changes
Dec 8, 2023
yuanlehome
reviewed
Dec 8, 2023
| if (sm_vesion != 70 && sm_vesion != 80 && sm_vesion != 86 && | ||
| sm_vesion != 75) { | ||
| // TODO(Wanglongzhi2001): only support sm80 for now | ||
| if (sm_vesion != 80) { |
There was a problem hiding this comment.
当前develop版本已经支持了70 75 80 86这四个架构
zyfncg
reviewed
Dec 12, 2023
| @@ -30,5 +30,7 @@ bool DtypeInterface::operator==(const DtypeInterface& other) const { | |||
| return *dtype_ == *other.dtype_; | |||
| } | |||
|
|
|||
| IrDtype DtypeInterface::dtype() const { return *(this->dtype_); } | |||
There was a problem hiding this comment.
这里返回类型直接用pir::Type吧，设计早起本来是不希望暴露太多pir的概念到上层，目前看pir::Type在drr中的使用场景比较有限，可以直接用
There was a problem hiding this comment.
是指像下面这样吗
pir::Type DtypeInterface::dtype() const { return this->dtype_->get(); }
yuanlehome
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-71502
修改了之前的 fused_weight_only_linear_pass 的 PR #59366