Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] fix rocm compile bugs #59775

Merged
merged 5 commits into from
Dec 8, 2023
Merged

[ROCM] fix rocm compile bugs #59775

merged 5 commits into from
Dec 8, 2023

Conversation

yuguo-Jack
Copy link
Contributor

@yuguo-Jack yuguo-Jack commented Dec 7, 2023 •
edited by YanhuiDua
Loading

PR types

Bug fixes

PR changes

OPs

Description

fix rocm compile bugs

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 7, 2023
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 7, 2023 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

qili93
qili93 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From00
From00 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onecatcn
Copy link
Contributor

onecatcn commented Dec 7, 2023

2023-12-07 10:16:30 0. You must be approved by phlrain or risemeup1 or zhangbo9674 or Galaxy1458 for using cc_test_old. Thanks!
2023-12-07 10:16:30 1. You must have one RD (From00, zhangbo9674) approval for file changes in paddle/fluid/framework/new_executor.

@YanhuiDua YanhuiDua merged commit e603865 into PaddlePaddle:develop Dec 8, 2023
28 of 29 checks passed
@YanhuiDua YanhuiDua changed the title fix rocm compile bugs [ROCM] fix rocm compile bugs Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qili93 qili93 qili93 approved these changes

@From00 From00 From00 approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@risemeup1 risemeup1 risemeup1 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yuguo-Jack @onecatcn @qili93 @From00 @tianshuo78520a @risemeup1 @YanhuiDua