Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOT] fix sot call locals #59710

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[SOT] fix sot call locals #59710

merged 2 commits into from
Dec 7, 2023

Conversation

feifei-111
Copy link
Contributor

@feifei-111 feifei-111 commented Dec 5, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

currently we will call locals by break graph, but this will lead to error in some cases, so we will fallback before simulate if locals is called

PCard-66972

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 5, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@feifei-111 feifei-111 changed the title fix sot call locals [SOT] fix sot call locals Dec 5, 2023
SigureMo
SigureMo approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit af5b940 into PaddlePaddle:develop Dec 7, 2023
28 of 29 checks passed
@feifei-111 feifei-111 deleted the fix_sot_call_locals branch December 12, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feifei-111 @SigureMo