【pir】deal with if build stop gradient #59585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winter-wang
reviewed
Dec 1, 2023
| for (size_t i = 0; i < op.num_operands(); ++i) { | ||
| argument.AddOutput(op.operand(i).type()); | ||
| bool input_stop_gradient = true; | ||
| auto input = op.operand_source(i).dyn_cast<pir::OpResult>(); |
There was a problem hiding this comment.
如果input不是OpResult，而是BlockArgument的话，这句返回的是空的OpResult。 下一句的defining_op返回的也是空指针。再后面会直接奔溃。
winter-wang
reviewed
Dec 1, 2023
| input_stop_gradient = | ||
| attrs[input.index()].dyn_cast<pir::BoolAttribute>().data(); | ||
| } | ||
| outs_stop_gradient.push_back(pir::BoolAttribute::get( |
There was a problem hiding this comment.
Suggested change
| outs_stop_gradient.push_back(pir::BoolAttribute::get( | |
| outs_stop_gradient.push_back(builder.bool_attr(input_stop_gradient)); |
winter-wang
reviewed
Dec 1, 2023
| } | ||
|
|
||
| argument.AddAttribute(kStopGradientAttrName, | ||
| pir::ArrayAttribute::get(pir::IrContext::Instance(), |
There was a problem hiding this comment.
Suggested change
| pir::ArrayAttribute::get(pir::IrContext::Instance(), | |
| pir::ArrayAttribute::get(builder.ir_context(), |
winter-wang
reviewed
Dec 1, 2023
|
|
||
| auto cond_ = cond.dyn_cast<pir::OpResult>(); | ||
| auto cond_op = cond_.owner(); | ||
| if (cond_op->HasAttribute(kStopGradientAttrName)) { |
There was a problem hiding this comment.
同理，如果这儿的cond是BlockArgument， 而不是OpResult， 这儿也会崩溃，且没有提示。
SigureMo
pushed a commit
to gouzil/Paddle
that referenced
this pull request
Dec 5, 2023
* merge * add stop gradient * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Description
pcard-67164
TODO