Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.266、269】 Migrate ldexp, logaddexp into pir #59582

Merged
merged 6 commits into from
Dec 7, 2023
Merged

【PIR API adaptor No.266、269】 Migrate ldexp, logaddexp into pir #59582

merged 6 commits into from
Dec 7, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Dec 1, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

PIR API 推全升级

No.266 paddle.Tensor.ldexp
No.269 paddle.Tensor.logaddexp

将 paddle.Tensor.ldexp 迁移升级至 pir，并更新单测 覆盖率1/1
将 paddle.Tensor.logaddexp 迁移升级至 pir，并更新单测 覆盖率0/0

@enkilee enkilee changed the title 【PIR API adaptor No.266、269】 Migrate ldexp/logaddexp into pir 【PIR API adaptor No.266、269】 Migrate ldexp, logaddexp into pir Dec 1, 2023
@luotao1 luotao1 mentioned this pull request Dec 1, 2023
Closed
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 1, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 1, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 4, 2023
MarioLulab
MarioLulab reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦更新一下单测覆盖率吧~

python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
MarioLulab
MarioLulab reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和研发确认了一下，目前 paddle 在做 python 端 Value 和 OpResult 统一的工作，后面应该就都用 Value 了。辛苦将本 pr 的 paddle.pir.OpResult --> paddle.pir.Value 吧

python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
MarioLulab
MarioLulab approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 79d808f into PaddlePaddle:develop Dec 7, 2023
28 of 29 checks passed
@enkilee enkilee deleted the pir-api-265-266 branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@MarioLulab MarioLulab MarioLulab approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enkilee @0x45f @MarioLulab @luotao1