[XPU][PHI Kernels] support fused_rotary_position_embedding for xpu #59480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
lj970926
commented
Nov 29, 2023
| if (use_neox_rotary_style) { | ||
| // TODO(lijin23): support rotary_embedding every_two. | ||
| PADDLE_THROW(phi::errors::Unimplemented( | ||
| "XPU do not support rotary_embedding with use_neox_rotary_style set.")); |
There was a problem hiding this comment.
相关API算子暂不支持fp16输入的sin、cos，待后续api支持后下个PR更新
lj970926
commented
Nov 29, 2023
| p_fw, p_bw = self.get_forward_backward( | ||
| paddle_fused_rotary_position_embedding, | ||
| seed=self.seed, | ||
| use_neox_rotary_style=False, |
There was a problem hiding this comment.
所有单测暂时指定use_neox_rotary_style=False，待后续支持后完善
XiaociZhang
reviewed
Nov 30, 2023
| from paddle.incubate.nn.functional import fused_rotary_position_embedding | ||
|
|
||
|
|
||
| def deal_qkv(init_q, init_k, init_v): |
There was a problem hiding this comment.
后续提交可以改个名字，permute_qkv类似这种
houj04
reviewed
Nov 30, 2023
houj04
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
support fused_rotary_position_embedding for xpu. Do not support
use_neox_rotary_style=Truetemporarily