Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auto parallel] Shard optimizer API #59342

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[auto parallel] Shard optimizer API #59342

merged 3 commits into from
Nov 30, 2023

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Nov 24, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

PCard-73145
Support shard optimizer API, which is used for mp and pp.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 24, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu force-pushed the shard_opt_py_api branch 3 times, most recently from d63d4b8 to e6e123c Compare November 27, 2023 06:48
@FeixLiu FeixLiu force-pushed the shard_opt_py_api branch 4 times, most recently from 90e68a6 to 2c2ac66 Compare November 29, 2023 08:10
ForFishes
ForFishes previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle deleted a comment from ForFishes Nov 29, 2023
ForFishes
ForFishes previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LiYuRio
LiYuRio previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 self-requested a review November 30, 2023 03:48
zhiqiu
zhiqiu previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/distributed/auto_parallel/api.py Show resolved Hide resolved
LiYuRio
LiYuRio previously approved these changes Nov 30, 2023
View reviewed changes
@FeixLiu FeixLiu requested a review from Ligoml November 30, 2023 06:51
Ligoml
Ligoml approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@FeixLiu FeixLiu requested a review from zhiqiu November 30, 2023 09:16
zhiqiu
zhiqiu approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit 13d00df into PaddlePaddle:develop Nov 30, 2023
29 checks passed
@FeixLiu FeixLiu deleted the shard_opt_py_api branch November 30, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@Ligoml Ligoml Ligoml approved these changes

@LiYuRio LiYuRio LiYuRio approved these changes

@ForFishes ForFishes ForFishes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FeixLiu @zhiqiu @jeff41404 @ForFishes @Ligoml @LiYuRio