Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XPU][PHI Kernels] use ctx_guard to allocate temporary buffer #59334

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[XPU][PHI Kernels] use ctx_guard to allocate temporary buffer #59334

merged 1 commit into from
Nov 27, 2023

Conversation

dynamicheart
Copy link
Contributor

@dynamicheart dynamicheart commented Nov 24, 2023 •
edited
Loading

PR types

Function optimization

PR changes

Others

Description

使用RAII的机制分配替换原有的xpu_malloc和xpu_free，避免内存泄露出现。

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 24, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 24, 2023
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 24, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

zhangyk0314
zhangyk0314 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cqulilujia
cqulilujia approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@cqulilujia cqulilujia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 24f25c8 into PaddlePaddle:develop Nov 27, 2023
28 checks passed
@dynamicheart dynamicheart deleted the xpu/ctx_guard branch November 27, 2023 03:38
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@dynamicheart @SecretXV
[XPU][PHI Kernels] use ctx_guard to allocate temporary buffer (Paddle…
70669d3 
…Paddle#59334)
@houj04 houj04 added the XPU label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqulilujia cqulilujia cqulilujia approved these changes

@houj04 houj04 houj04 approved these changes

@zhangyk0314 zhangyk0314 zhangyk0314 approved these changes

Assignees
No one assigned
Labels
contributor External developers XPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dynamicheart @CLAassistant @cqulilujia @houj04 @zhangyk0314