[OneDNN] Replace cpu.h header in default OneDNN to deploy #59259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
2 times, most recently
from
4b98eec
to
6f22ecc
Compare
|
@xinyu-intel @vivienfanghuagood , please help review, thanks~ |
xinyu-intel
previously approved these changes
Nov 23, 2023
|
您好，我有一些建议：
|
|
或者您可以在Predictor的构造函数里（paddle/fluid/inference/api/analysis_predictor.cc），当满足条件时，调用config.EnableMKLDNN(); |
|
@yuanlehome ，好的，多谢解答，感觉第二种思路会更好一些 |
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
from
6f22ecc
to
6373091
Compare
yuanlehome
reviewed
Nov 23, 2023
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
4 times, most recently
from
40bc60e
to
535ba48
Compare
|
@yuanlehome 能否帮忙看下这样是否合理，这样就不需要对每一个config的构造函数赋值了 |
恩 我认为是合理的～ |
zhanglirong1999
force-pushed
the
oneDNN_default_cpu_header_fix
branch
from
535ba48
to
ee27949
Compare
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…le#59259) * Fix cpu.h header can not package in deploy * run CI * Add win32 header * enable mkldnn in predictor not in config * delete useless code * change logic to filter avx * fix * make use_mkldnn_ = false * exchange position to coverage CI pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
cpu.h header in default OneDNN will have error in deploy causing by this header files cannot be exposed to the outside world and packaged.