Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adam/adamw infer shape spmd #59185

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Nov 21, 2023

PR types

Others

PR changes

Others

Description

Support spmd for Adamw:

  1. R + S -> shard R
  2. R + P -> replicate P

PCard-73145

infer shape中对master param等optional的参数做initialized判断的原因:
image

Copy link

paddle-bot bot commented Nov 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu force-pushed the add_rule_for_adamw branch 5 times, most recently from b3cc664 to f186219 Compare November 22, 2023 04:19
Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit 6ca1b8e into PaddlePaddle:develop Nov 23, 2023
@FeixLiu FeixLiu deleted the add_rule_for_adamw branch November 23, 2023 03:04
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants