[PIR] Enable program translator in dy2st mode #59152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
…program_translator_in_dy2st
kangguangli
requested review from
Aurelius84,
yuanlehome,
SigureMo,
2742195759 and
0x45f
Aurelius84
reviewed
Nov 23, 2023
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <iostream> | |||
| core._is_fwd_prim_enabled() or core._is_bwd_prim_enabled() | ||
| ) | ||
| in_cinn_backend = self._backend == "CINN" | ||
| is_cinn_enabled = self._build_strategy.build_cinn_pass |
There was a problem hiding this comment.
Suggested change
| is_cinn_enabled = self._build_strategy.build_cinn_pass | |
| is_cinn_enabled = self._build_strategy.build_cinn_pass or self._backend == "CINN" |
可以省去一个变量
Aurelius84
approved these changes
Nov 23, 2023
好的，下个PR修复。 |
heavengate
approved these changes
Nov 23, 2023
vivienfanghuagood
approved these changes
Nov 23, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* enable program translator in dy2st mode * fix * test * test * test * test * fix * fix test_eager_run_program.py * fix test_run_program_op * fix test_gradname_parse partially * fix test_bert_cinn * skip failed cases * skip jit.save * fix test_run_program_op * fix * fix * fix * fix * fix
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Enable program translator in dy2st mode, but disable in following cases:
Additional Modifications
in_pir_pt_modeforrun_porgramopenable_pir_with_pt_in_dy2stBoth of them is used to control whether Pir is enabled in dy2st mode.
Others
Pcard-67164