update dygraph auto parallel API interface. #59059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
wuhuachao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
wuhuachaocoding
force-pushed
the
modify_API
branch
from
ddb8733
to
ef3a6f7
Compare
wuhuachaocoding
force-pushed
the
modify_API
branch
from
b07083f
to
5cc36a9
Compare
wuhuachaocoding
force-pushed
the
modify_API
branch
4 times, most recently
from
9089746
to
2519e63
Compare
wuhuachaocoding
force-pushed
the
modify_API
branch
from
2519e63
to
cc47be5
Compare
|
|
||
| from paddle.base.core import Partial, Placement, ReduceType, Replicate, Shard | ||
|
|
||
| __all__ = ["ReduceType", "Placement", "Replicate", "Shard", "Partial"] |
There was a problem hiding this comment.
- ReduceType 和其他类型命名方式不太一样，多了个Type的后缀，是否需要统一？
- placement_type 包含 Placement，这两个概念有包含关系，Placement是一种什么样的placement_type呢？
- 这几个API不需要放到__all__列表，根据调用方式，只放到paddle.distributed.init.py的__all__列表就行
XiaoguangHu01
approved these changes
Nov 27, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Co-authored-by: wuhuachao <wuhuachao@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
update dygraph auto parallel API interface.
Pcard-73145