Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto parallal] add spmd rule for cast #59050

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Nov 16, 2023

PR types

Others

PR changes

Others

Description

Pcard-73145
add spmd rule for cast

@FeixLiu FeixLiu force-pushed the add_cast_spmd branch 3 times, most recently from 5398640 to 543ce36 Compare November 16, 2023 23:41
Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,8 +27,10 @@ def setUp(self):
self._changeable_envs = {"backend": ["cpu", "gpu"]}

def test_matmul_api(self):
default_envs = self._default_envs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不 deep copy ,其实会影响其他的测试;这是符合预期的吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有很大的影响,的确和预期不太相符。但是不影响其他单测,下个pr可以修一下

@FeixLiu FeixLiu merged commit df81ec6 into PaddlePaddle:develop Nov 17, 2023
28 checks passed
@FeixLiu FeixLiu deleted the add_cast_spmd branch November 17, 2023 08:55
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants