add MergedAdamKernel and test for MergedAdamKernel and fix adam caculation process in test #58982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation process in test
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
houj04
approved these changes
Nov 16, 2023
| import paddle | ||
|
|
||
| # from op import Operator | ||
| # from op_test_xpu import XPUOpTest |
There was a problem hiding this comment.
收到，我这周还会提一个pr，到时候顺便把这里删掉：）
QingshuChen
reviewed
Nov 16, 2023
|
|
||
| // update param, moment1, moment2 | ||
| for (int i = 0; i < param_num; i++) { | ||
| phi::Copy(dev_ctx, *param[i], dev_ctx.GetPlace(), false, param_out[i]); |
There was a problem hiding this comment.
这个确实是导致mergedAdam性能不够好的问题之一，原因就是api的算子接口没有按照标准的inplace来写，而pytorch那边不希望我们更改接口，所以只能暂时这样
qili93
approved these changes
Nov 16, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…ation process in test (PaddlePaddle#58982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description