[XPU][PHI Kernels] bind rsqrt、bitwise_or、arange_tensor for xpu #58950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lj970926
commented
Nov 16, 2023
| {"arange_tensor", | ||
| XPUKernelSet({phi::DataType::FLOAT32, | ||
| phi::DataType::INT32, | ||
| phi::DataType::INT64})}, |
There was a problem hiding this comment.
#58381 这个PR把kernel的名字从arange改成了arange_tensor，导致xpu不能从xpu2/3_op_list中找到对应的kernel信息从而触发fallback
lj970926
commented
Nov 16, 2023
|
|
||
| int ret = xpu::range<T>( | ||
| dev_ctx.x_context(), out_data, start_value, step_value, size); | ||
| PADDLE_ENFORCE_XDNN_SUCCESS(ret, "range"); |
There was a problem hiding this comment.
原来的CPU实现替换为xpu::range
lj970926
commented
Nov 16, 2023
| DenseTensor* out) { | ||
| // Same reason as bitwise_and | ||
| LogicalOrKernel<T, Context>(ctx, x, y, out); | ||
| } |
There was a problem hiding this comment.
bitwise_or之前已有已有单测
houj04
approved these changes
Nov 16, 2023
QingshuChen
approved these changes
Nov 16, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…ePaddle#58950) * bind kernels * add tests * bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description