【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir #58911

enkilee · 2023-11-10T08:56:49Z

PR types

Others

PR changes

APIs

Description

新IR Python API适配升级 #58067
No.87

PIR API 推全升级
将 paddle.incubate.nn.functional.fused_rotary_position_embedding 迁移升级至 pir，并更新单测单测覆盖率：1/1

paddle-bot · 2023-11-10T12:38:17Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

MarioLulab

FusedLinear: 在 test/legacy_test/test_fused_matmul_bias.py 里有相关静态图单测
FusedMultiTransformer ：在 test/legacy_test/test_fused_multi_transformer_op.py 有相关静态图单测
麻烦为这些单测打开 pir 测试的开关吧~

python/paddle/incubate/nn/functional/fused_matmul_bias.py

python/paddle/incubate/nn/functional/fused_transformer.py

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

0x45f · 2023-11-23T07:01:17Z

fused_gemm_epilogue OP目前还没有迁移到phi下，可以先跳过这个api，适配其他的api并打开对应单测

python/paddle/incubate/nn/functional/fused_matmul_bias.py

MarioLulab

既然 fused_gemm_epilogue 还无法适配 pir，那么麻烦请修改一下 pr 标题和 pr 描述吧，把 paddle.incubate.nn.FusedLinear, paddle.incubate.nn.functional.fused_linear_activation, paddle.incubate.nn.functional.fused_matmul_bias 删除

test/legacy_test/test_fused_multi_transformer_op.py

MarioLulab · 2023-11-30T02:17:13Z

PR 标题的前缀题号应该是：【PIR API adaptor No.86、87】
麻烦修改一下吧

0x45f · 2023-11-30T06:21:24Z

TestFusedMultiTransformerOp.test_fused_multi_transformer_op测试为什么没有打开pir的测试呀？另外更新下pr描述吧~

MarioLulab · 2023-12-01T08:34:17Z

TestFusedMultiTransformerOp.test_fused_multi_transformer_op测试为什么没有打开pir的测试呀？另外更新下pr描述吧~

因为这个单测是动态图单测，所以没有打开 pir 测试

test/legacy_test/test_fused_multi_transformer_op.py

0x45f · 2023-12-04T07:09:10Z

本地有跑过test/legacy_test/test_fused_multi_transformer_op.py这个单测吗？ci上这个单测被禁了，所以没有这个文件没有被跑到。我看单测中的GetFusedMultiTransformerOutStatic函数在PIR下执行应该还是会有问题，建议在本地跑一下，修复一下相关的问题~

enkilee · 2023-12-04T09:06:31Z

本地有跑过test/legacy_test/test_fused_multi_transformer_op.py这个单测吗？ci上这个单测被禁了，所以没有这个文件没有被跑到。我看单测中的GetFusedMultiTransformerOutStatic函数在PIR下执行应该还是会有问题，建议在本地跑一下，修复一下相关的问题~

额，本地没环境跑，我看静态是跑在GPU下的。抱歉。

MarioLulab · 2023-12-06T02:23:16Z

本地有跑过test/legacy_test/test_fused_multi_transformer_op.py这个单测吗？ci上这个单测被禁了，所以没有这个文件没有被跑到。我看单测中的GetFusedMultiTransformerOutStatic函数在PIR下执行应该还是会有问题，建议在本地跑一下，修复一下相关的问题~

额，本地没环境跑，我看静态是跑在GPU下的。抱歉。

那我在本地用 GPU 环境运行一下吧~ 有进展了会在这个 pr 下 comment 😄

MarioLulab · 2023-12-07T03:02:04Z

当前 fused_multi_transformer 的 kernel 还没有从 fluid 迁移到 phi 体系下，所以目前 fused_multi_transformer 这个 pir api 的迁移工作可以先搁置。这个 pr 暂时只保留 fused_rotary_position_embedding 的工作吧。麻烦复原一下 fused_multi_transformer 及其单测代码，并修改本 pr 标题 🤝

enkilee · 2023-12-07T06:41:17Z

当前 fused_multi_transformer 的 kernel 还没有从 fluid 迁移到 phi 体系下，所以目前 fused_multi_transformer 这个 pir api 的迁移工作可以先搁置。这个 pr 暂时只保留 fused_rotary_position_embedding 的工作吧。麻烦复原一下 fused_multi_transformer 及其单测代码，并修改本 pr 标题 🤝

收到，辛苦佬🤝🤝

enkilee added 3 commits November 10, 2023 07:48

fix

9b6e111

fix tst

8c0cb05

fix

0752f0a

paddle-bot bot added the contributor External developers label Nov 10, 2023

fix

c05e91e

luotao1 mentioned this pull request Nov 13, 2023

新IR Python API适配升级 #58067

Closed

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 13, 2023

luotao1 assigned luotao1, 0x45f, YuanRisheng and MarioLulab Nov 13, 2023

enkilee added 2 commits November 13, 2023 04:41

fix

82385fa

fix

efba0c6

MarioLulab reviewed Nov 13, 2023

View reviewed changes

python/paddle/incubate/nn/functional/fused_matmul_bias.py Outdated Show resolved Hide resolved

python/paddle/incubate/nn/functional/fused_matmul_bias.py Outdated Show resolved Hide resolved

python/paddle/incubate/nn/functional/fused_transformer.py Outdated Show resolved Hide resolved

enkilee and others added 12 commits November 14, 2023 13:17

Update python/paddle/incubate/nn/functional/fused_matmul_bias.py

d7be80c

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

Update python/paddle/incubate/nn/functional/fused_matmul_bias.py

aa58fcb

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

Update python/paddle/incubate/nn/functional/fused_transformer.py

d1cdc41

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

fix

1e10eb3

Merge branch 'PaddlePaddle:develop' into pir-api-75

6c3d9f0

fix indent

60dc398

fix

8d95c53

fix

7bb808d

fix

04c9a02

fix

2ca1e3f

unchanged randint_like

9527aa4

Merge branch 'PaddlePaddle:develop' into pir-api-75

63a086a

fix

dea41dc

MarioLulab reviewed Nov 24, 2023

View reviewed changes

python/paddle/incubate/nn/functional/fused_matmul_bias.py Outdated Show resolved Hide resolved

fix

4d84ac4

MarioLulab reviewed Nov 28, 2023

View reviewed changes

test/legacy_test/test_fused_multi_transformer_op.py Outdated Show resolved Hide resolved

fix

2dc73d8

enkilee changed the title ~~【PIR API adaptor No.83-87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir~~ 【PIR API adaptor No.86，87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir Nov 30, 2023

enkilee changed the title ~~【PIR API adaptor No.86，87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir~~ 【PIR API adaptor No.86、87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir Nov 30, 2023

fix

d69b569

MarioLulab reviewed Dec 1, 2023

View reviewed changes

test/legacy_test/test_fused_multi_transformer_op.py Outdated Show resolved Hide resolved

fix

2b99680

enkilee changed the title ~~【PIR API adaptor No.86、87】Migrate FusedMultiTransformer，fused_rotary_position_embedding into pir~~ 【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir Dec 7, 2023

fix

6f59ea7

0x45f approved these changes Dec 8, 2023

View reviewed changes

0x45f merged commit c45faed into PaddlePaddle:develop Dec 8, 2023
28 of 29 checks passed

enkilee deleted the pir-api-75 branch December 14, 2023 08:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir #58911

【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir #58911

enkilee commented Nov 10, 2023 •

edited

Loading

paddle-bot bot commented Nov 10, 2023

MarioLulab left a comment •

edited

Loading

0x45f commented Nov 23, 2023

MarioLulab left a comment

MarioLulab commented Nov 30, 2023

0x45f commented Nov 30, 2023 •

edited

Loading

MarioLulab commented Dec 1, 2023

0x45f commented Dec 4, 2023

enkilee commented Dec 4, 2023

MarioLulab commented Dec 6, 2023

MarioLulab commented Dec 7, 2023

enkilee commented Dec 7, 2023

【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir #58911

【PIR API adaptor No.87】Migrate fused_rotary_position_embedding into pir #58911

Conversation

enkilee commented Nov 10, 2023 • edited Loading

PR types

PR changes

Description

paddle-bot bot commented Nov 10, 2023

MarioLulab left a comment • edited Loading

Choose a reason for hiding this comment

0x45f commented Nov 23, 2023

MarioLulab left a comment

Choose a reason for hiding this comment

MarioLulab commented Nov 30, 2023

0x45f commented Nov 30, 2023 • edited Loading

MarioLulab commented Dec 1, 2023

0x45f commented Dec 4, 2023

enkilee commented Dec 4, 2023

MarioLulab commented Dec 6, 2023

MarioLulab commented Dec 7, 2023

enkilee commented Dec 7, 2023

enkilee commented Nov 10, 2023 •

edited

Loading

MarioLulab left a comment •

edited

Loading

0x45f commented Nov 30, 2023 •

edited

Loading