[AutoParallel] Set value phi yaml #58893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set_value_phi_yaml
… set_value_phi_yaml
wanghuancoder
commented
Nov 13, 2023
| @@ -1573,10 +1573,10 @@ def test_forward_version(self): | |||
| self.assertEqual(var.inplace_version, 1) | |||
|
|
|||
| inplace_var[0] = 2 | |||
| self.assertEqual(var.inplace_version, 1) | |||
| self.assertEqual(var.inplace_version, 2) | |||
|
|
|||
There was a problem hiding this comment.
这里的修改是因为原来对set_value的inplace处理是错的，而单测“迎合”了错误的处理逻辑。这里给修改掉
| @@ -829,7 +829,6 @@ def test_setitem(self): | |||
| np.testing.assert_allclose(out[1, 2, 3, 4], np.array(10)) | |||
| self.assertEqual(x.grad.shape, [2, 3, 4, 5]) | |||
| x_grad_expected = np.ones((2, 3, 4, 5)) * 2 | |||
| x_grad_expected[1, 2, 3, 4] = 0 | |||
There was a problem hiding this comment.
这里之所以删掉是因为，原来中间态set_value的反向，不管有没有ValueTensor都调set_value_grad。但按着Maker的表述，如果有ValueTensor调set_value_grad，否则调assign。单测这里迎合了中间态的产品形态。
zyfncg
reviewed
Nov 13, 2023
| @@ -829,7 +829,6 @@ def test_setitem(self): | |||
| np.testing.assert_allclose(out[1, 2, 3, 4], np.array(10)) | |||
| self.assertEqual(x.grad.shape, [2, 3, 4, 5]) | |||
| x_grad_expected = np.ones((2, 3, 4, 5)) * 2 | |||
| x_grad_expected[1, 2, 3, 4] = 0 | |||
There was a problem hiding this comment.
这里之所以删掉是因为，原来中间态set_value的反向，不管有没有ValueTensor都调set_value_grad。但按着Maker的表述，如果有ValueTensor调set_value_grad，否则调assign。单测这里迎合了中间态的产品形态。
zyfncg
approved these changes
Nov 13, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* set value to phi
Merged
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* set value to phi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
将set value迁移至PHI yaml。动态图走最终态。并支持AutoParallel
Pcard-73145