Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rms norm when dy2static #58868

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

RichardWooSJTU
Copy link
Contributor

@RichardWooSJTU RichardWooSJTU commented Nov 9, 2023

PR types

Bug fixes

PR changes

APIs

Description

Optinonal input should use template as follows to avoid failing in dy2static:

def xxx(x, y = None): # y is optional
    if y is not None:
            xxxx

Pcard-71502

Copy link
Contributor

@wwbitejotunn wwbitejotunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanlehome yuanlehome merged commit 0a3b495 into PaddlePaddle:develop Nov 10, 2023
28 checks passed
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants