Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.247】python/paddle/text/viterbi_decode.py #58785

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Nov 7, 2023

PR types

Others

PR changes

APIs

Description

#58067 247

单测覆盖率:2/2

@paddle-bot paddle-bot bot added the contributor External developers label Nov 7, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 8, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~
但是有一个单测遗漏掉了,麻烦修改一下吧

test/legacy_test/test_viterbi_decode_op.py Show resolved Hide resolved
@Liyulingyue
Copy link
Contributor Author

Liyulingyue commented Nov 9, 2023

@MarioLulab 感觉似乎这个失败的单侧和修改部分没关联?麻烦帮忙看一下

@MarioLulab
Copy link
Contributor

@MarioLulab 感觉似乎这个失败的单侧和修改部分没关联?麻烦帮忙看一下

确实是没关系的。我叫研发来 re-run 一下 🤣

@0x45f 0x45f merged commit 7007d8f into PaddlePaddle:develop Nov 10, 2023
28 checks passed
@Liyulingyue Liyulingyue deleted the 247 branch January 15, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants