Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.132】 Migrate paddle.Tensor.paddle.Tensor.logcumsumexp #58695

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

xiaoyewww
Copy link
Contributor

@xiaoyewww xiaoyewww commented Nov 5, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将 paddle.Tensor.log2 迁移升级至 pir,并更新单测

#58067

单测覆盖率:4/5

存在问题:
pir下test_name测例,不支持name属性的访问:

1256: test_logcumsumexp_op failed
1256:  ..E.ss.........
1256: ======================================================================
1256: ERROR: test_name (test_logcumsumexp_op.TestLogcumsumexp)
1256: ----------------------------------------------------------------------
1256: Traceback (most recent call last):
1256:   File "/wuzp/Paddle/build/python/paddle/pir_utils.py", line 119, in impl
1256:     func(*args, **kwargs)
1256:   File "/wuzp/Paddle/build/test/legacy_test/test_logcumsumexp_op.py", line 207, in test_name
1256:     self.assertTrue('out' in y.name)
1256: ValueError: (InvalidArgument) Currently, we can only get name of OpResult that is persistable (at /wuzp/Paddle/paddle/fluid/pybind/pir.cc:665)
1256: 
1256: 
1256: ----------------------------------------------------------------------

@paddle-bot paddle-bot bot added the contributor External developers label Nov 5, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 6, 2023
@MarioLulab
Copy link
Contributor

我看到 ci 挂在了 'paddle.base.libpaddle.pir.OpResult' object has no attribute 'backward'。当前 pir 暂不支持 backward 等相关接口,在后续 pir 反向传播的推全工作中才会涉及~ 所以先把 test/legacy_test/test_zero_dim_tensor.py 的相关单测还原吧

@xiaoyewww
Copy link
Contributor Author

我看到 ci 挂在了 'paddle.base.libpaddle.pir.OpResult' object has no attribute 'backward'。当前 pir 暂不支持 backward 等相关接口,在后续 pir 反向传播的推全工作中才会涉及~ 所以先把 test/legacy_test/test_zero_dim_tensor.py 的相关单测还原吧

已还原,麻烦重新review一下~

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 7806bff into PaddlePaddle:develop Nov 7, 2023
28 checks passed
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@xiaoyewww xiaoyewww deleted the new-ir/logcumsumexp branch November 8, 2023 05:56
Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants