[Prim][PIR] Sink layer_norm forward prim rule #58679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
cyber-pioneer
force-pushed
the
move_ln
branch
from
3a200a9 to
012e850
Compare
Charles-hit
previously approved these changes
Nov 13, 2023
|
|
||
|
|
||
| # xshape output will no longer used after decomp, but return none to keep output num the same as origin op | ||
| decomp_output_unused_op = ["squeeze", "unsqueeze"] |
There was a problem hiding this comment.
有算子拆解后，部分intermediate 输出将不再需要，组合机制里不再生成这些输出。
python/paddle/base/core.py
Outdated
| @@ -503,6 +503,8 @@ def _get_batch_norm_none_var(op): | |||
| "unsqueeze2": ["XShape"], | |||
| } | |||
|
|
|||
| pir_ops_contain_none = ["pd_op.squeeze", "pd_op.unsqueeze"] | |||
There was a problem hiding this comment.
这儿最好加一下注释表示中间输出拆解后可能部分算子会变为none
Charles-hit
reviewed
Nov 15, 2023
| @@ -503,6 +503,9 @@ def _get_batch_norm_none_var(op): | |||
| "unsqueeze2": ["XShape"], | |||
| } | |||
|
|
|||
| # some intermediate outputs like xshape will no longer used after decomp, but return none to keep output num the same as origin op | |||
| decomp_ops_list_contain_unused_output = ["pd_op.squeeze", "pd_op.unsqueeze"] | |||
There was a problem hiding this comment.
这儿后续可以放到decomposition目录下
There was a problem hiding this comment.
后续会自动生成，放在这个目录下面
Charles-hit
approved these changes
Nov 15, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* pir sink decomp support symbol overload * fix code * move layer_norm * support layer_norm op * fix code * add type cast * remove unused code * fix code * fix code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-66975
Sink layer_norm forward prim rule