[XPU] add bfloat16 support for gaussian and uniform #58662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
QingshuChen
reviewed
Nov 6, 2023
| using XPUType = typename XPUTypeTrait<T>::Type; | ||
| int64_t real_seed = seed != 0 ? seed : dev_ctx.GetGenerator()->Random64(); | ||
|
|
||
| // int random(Context* ctx, T* x, int64_t len, T min, T max, int64_t seed); |
There was a problem hiding this comment.
cpu的分支是否需要保留？
一个需求是用相同的初始化seed，然后xpu/cpu对比输出，xpu::random的结果和cpu能对齐？
There was a problem hiding this comment.
这种场景下面用export XPU_BLACK_LIST="uniform_random,gaussian_random"的办法解决？
目前gaussian_random也没有保留“从CPU拷贝”的功能。
QingshuChen
approved these changes
Nov 6, 2023
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
* [XPU] add bfloat16 support for gaussian and uniform * fix zero dim.
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* [XPU] add bfloat16 support for gaussian and uniform * fix zero dim.
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* [XPU] add bfloat16 support for gaussian and uniform * fix zero dim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
给XPU下的
gaussian和uniform算子增加bfloat16的类型支持。此外，在之前的
UniformKernel中，没有使用XDNN提供的API，原因未知。本PR把它的实现改成了直接调用XDNN提供的random函数。