-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRR] Create PatternRewritePass in pass.h #58655
Merged
yuanlehome
merged 12 commits into
PaddlePaddle:develop
from
gongshaotian:drr_rewriteBase
Nov 15, 2023
Merged
[DRR] Create PatternRewritePass in pass.h #58655
yuanlehome
merged 12 commits into
PaddlePaddle:develop
from
gongshaotian:drr_rewriteBase
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
gongshaotian
changed the title
[DRR] Create DrrBasePass API
[DRR] Create PatternPass in pass.h
Nov 6, 2023
yuanlehome
reviewed
Nov 6, 2023
paddle/cinn/hlir/dialect/operator/transforms/add_broadcast_to_elementwise_pass.cc
Outdated
Show resolved
Hide resolved
zyfncg
reviewed
Nov 6, 2023
gongshaotian
commented
Nov 6, 2023
zyfncg
previously approved these changes
Nov 6, 2023
yuanlehome
reviewed
Nov 6, 2023
gongshaotian
changed the title
[DRR] Create PatternPass in pass.h
[DRR] Create PatternRewritePass in pass.h
Nov 7, 2023
yuanlehome
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* create class DrrBasePass * add PatternPass in pass.h * Change the RewritePattern type pass from inheriting Pass to inheriting PatternPass * Rename PatternPass as PatternRewritePass and delete CanApplyOn() func * fix bug * Fix compilation bugs * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
Pcard-67164