Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.106】 Migrate paddle.i0e into pir #58604

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

PommesPeter
Copy link
Contributor

@PommesPeter PommesPeter commented Nov 2, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
paddle.i0e 迁移升级至 pir,并更新单测

单测覆盖率:8/8

问题:
对于 i0e_ 缺少对应的 inplace 算子,是否需要添加?

#58067

@MarioLulab
Copy link
Contributor

虽然 i0e_ 缺少对应的 inplace 算子,但在本次任务中不需要添加 inplace 算子 ~

@PommesPeter
Copy link
Contributor Author

虽然 i0e_ 缺少对应的 inplace 算子,但在本次任务中不需要添加 inplace 算子 ~

好的,收到

@paddle-bot paddle-bot bot added the contributor External developers label Nov 2, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
btw, 麻烦咋 PR 描述里添加单测覆盖率吧

@0x45f 0x45f merged commit 18b93c5 into PaddlePaddle:develop Nov 6, 2023
28 checks passed
@PommesPeter
Copy link
Contributor Author

LGTM btw, 麻烦咋 PR 描述里添加单测覆盖率吧

done

zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants