Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concat spmd rule #58506

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Concat spmd rule #58506

merged 9 commits into from
Nov 1, 2023

Conversation

liuzhenhai93
Copy link
Contributor

@liuzhenhai93 liuzhenhai93 commented Oct 30, 2023 •
edited
Loading

PR types

New features

PR changes

Others

Description

  • code gen 支持 vector 输入的切分推导
  • 切分推导兼容vector 输入
  • 实现 concat 切分推导规则
  • card-76948 code

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 30, 2023
wanghuancoder
wanghuancoder previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenwhql
chenwhql reviewed Oct 31, 2023
View reviewed changes
paddle/phi/api/lib/api_custom_impl.cc Outdated Show resolved Hide resolved
paddle/phi/infermeta/spmd_rules/concat.h Outdated Show resolved Hide resolved
test/auto_parallel/semi_auto_parallel_for_matmul.py Outdated Show resolved Hide resolved
GhostScreaming
GhostScreaming approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 21d7d04 into PaddlePaddle:develop Nov 1, 2023
28 checks passed
@GhostScreaming GhostScreaming mentioned this pull request Nov 2, 2023
Merged
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@liuzhenhai93 @zeroRains
Concat spmd rule (PaddlePaddle#58506)
67beae3 
* concat spmd rule

* polish

* polish

* polish

* polish

* polish

* recommitt
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@liuzhenhai93
Concat spmd rule (PaddlePaddle#58506)
d23f1dd 
* concat spmd rule

* polish

* polish

* polish

* polish

* polish

* recommitt
@liuzhenhai93 liuzhenhai93 deleted the concat_spmd_rule branch November 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JZ-LIANG JZ-LIANG JZ-LIANG left review comments

@chenwhql chenwhql chenwhql approved these changes

@GhostScreaming GhostScreaming GhostScreaming approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@liuzhenhai93 @CLAassistant @chenwhql @GhostScreaming @wanghuancoder @JZ-LIANG @raindrops2sea