Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.41、138、153】 Migrate paddle.complex, paddle.logspace, paddle.meshgrid into pir #58491

Merged
merged 4 commits into from
Nov 1, 2023
Merged

【PIR API adaptor No.41、138、153】 Migrate paddle.complex, paddle.logspace, paddle.meshgrid into pir #58491

merged 4 commits into from
Nov 1, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Oct 30, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

PIR API 推全升级

No.41 将 paddle.complex 迁移升级至 pir，并更新单测 单测覆盖率：5/5
No.138 将 paddle.logspace 迁移升级至 pir，并更新单测 单测覆盖率：8/12
No.153 将 paddle.meshgrid 迁移升级至 pir，并更新单测 单测覆盖率：7/12

MarioLulab
MarioLulab suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在 PR 描述里说明一下：test/legacy_test/test_logspace.py 中的 TestLogspaceAPI.test_name 和 TestLogspaceOpError 尚不支持

@paddle-bot paddle-bot bot added the contributor External developers label Oct 30, 2023
@luotao1 luotao1 mentioned this pull request Oct 31, 2023
Closed
@0x45f
Copy link
Contributor

0x45f commented Oct 31, 2023

logspace的适配有点问题，在调用_C_ops.logspace之前有一些检查的逻辑没有适配。可以参考creation.py文件arange API 1378行附近的代码，适配之后可以尝试在打开logspace的相关单测~

@0x45f
Copy link
Contributor

0x45f commented Oct 31, 2023

meshgrid单测3个继承自TestCase单测报错是因为在新IR下program用到了老的program，以TestMeshgridOp3为例，可以尝试做类似如下的修改
image

@enkilee
Copy link
Contributor Author

enkilee commented Nov 1, 2023

already done.

MarioLulab
MarioLulab approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0x45f
0x45f approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 11dd196 into PaddlePaddle:develop Nov 1, 2023
28 checks passed
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 2, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@enkilee @zeroRains
【PIR API adaptor No.41、138、153】 Migrate paddle.complex, paddle.logspa…
0c530bd 
…ce, paddle.meshgrid into pir (PaddlePaddle#58491)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@enkilee
【PIR API adaptor No.41、138、153】 Migrate paddle.complex, paddle.logspa…
4596978 
…ce, paddle.meshgrid into pir (PaddlePaddle#58491)
@enkilee enkilee deleted the pir-api-creation branch December 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@MarioLulab MarioLulab MarioLulab approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enkilee @0x45f @MarioLulab @luotao1