Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.225、227、197、187、152】 Migrate tanhshrink/thresholded_relu/Selu/RRelu/maxout into pir #58429

Merged
merged 11 commits into from
Nov 13, 2023
Merged

【PIR API adaptor No.225、227、197、187、152】 Migrate tanhshrink/thresholded_relu/Selu/RRelu/maxout into pir #58429

merged 11 commits into from
Nov 13, 2023

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Oct 26, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

No.225、227、197、187与 152
PIR API 推全升级

将 tanhshrink 迁移升级至 pir，并更新单测 单测覆盖率：3/4
将 thresholded_relu 迁移升级至 pir，并更新单测 单测覆盖率：3/4
将 Selu 迁移升级至 pir，并更新单测 单测覆盖率：3/4
将 maxout 迁移升级至 pir，并更新单测 单测覆盖率：3/4

tanhshrink / thresholded_relu / Selu / maxout / RRelu 这5个的 test_errors 都存在问题

将 RRelu 迁移升级至 pir，并更新单测 单测覆盖率：11/14

test_error_functional 和 test_error_layer 存在问题

======================================================================
2023-10-31 23:39:17 ERROR: test_static_graph_functional (test_rrelu_op.TestFunctionalRReluAPI)
2023-10-31 23:39:17 test_static_graph_functional
2023-10-31 23:39:17 ----------------------------------------------------------------------
2023-10-31 23:39:17 AttributeError: 'Operator' object has no attribute 'name'
2023-10-31 23:39:17 ======================================================================
2023-10-31 23:39:17 ERROR: test_static_graph_layer (test_rrelu_op.TestFunctionalRReluAPI)
2023-10-31 23:39:17 test_static_graph_layer
2023-10-31 23:39:17 ----------------------------------------------------------------------
2023-10-31 23:39:17 AttributeError: 'Operator' object has no attribute 'name'
2023-10-31 23:39:17 ----------------------------------------------------------------------

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 26, 2023
@DrRyanHuang DrRyanHuang changed the title 【PIR API adaptor No.221】 Migrate tanhshrink/thresholded_relu/Selu/RRelu into pir 【PIR API adaptor No.221】 Migrate tanhshrink/thresholded_relu/Selu/RRelu/maxout into pir Oct 26, 2023
@DrRyanHuang DrRyanHuang changed the title 【PIR API adaptor No.221】 Migrate tanhshrink/thresholded_relu/Selu/RRelu/maxout into pir 【PIR API adaptor No.225、227、197、187、152】 Migrate tanhshrink/thresholded_relu/Selu/RRelu/maxout into pir Oct 26, 2023
@Ligoml Ligoml mentioned this pull request Oct 27, 2023
Closed
@DrRyanHuang DrRyanHuang marked this pull request as draft October 30, 2023 02:00
0x45f
0x45f reviewed Oct 30, 2023
View reviewed changes
test/legacy_test/test_activation_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_activation_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_maxout_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_rrelu_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_selu_op.py Outdated Show resolved Hide resolved
@DrRyanHuang DrRyanHuang marked this pull request as ready for review October 31, 2023 14:59
MarioLulab
MarioLulab suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~ 但是有一些单测缺失，需要补上

test/legacy_test/test_activation_op.py Show resolved Hide resolved
test/legacy_test/test_activation_op.py Show resolved Hide resolved
test/legacy_test/test_rrelu_op.py Show resolved Hide resolved
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
MarioLulab
MarioLulab suggested changes Nov 9, 2023
View reviewed changes
test/legacy_test/test_rrelu_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_rrelu_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_rrelu_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_rrelu_op.py Outdated Show resolved Hide resolved
MarioLulab
MarioLulab approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit da292d3 into PaddlePaddle:develop Nov 13, 2023
28 checks passed
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@DrRyanHuang
【PIR API adaptor No.225、227、197、187、152】 Migrate tanhshrink/threshold…
a15659b 
…ed_relu/Selu/RRelu/maxout into pir (PaddlePaddle#58429)
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@DrRyanHuang @SecretXV
【PIR API adaptor No.225、227、197、187、152】 Migrate tanhshrink/threshold…
305637b 
…ed_relu/Selu/RRelu/maxout into pir (PaddlePaddle#58429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@MarioLulab MarioLulab MarioLulab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrRyanHuang @0x45f @MarioLulab