Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] Support elementwise_min/max/floordiv/where more precision types for KL1 and KL2 #58422

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

newway
Copy link
Contributor

@newway newway commented Oct 26, 2023

PR types

New features

PR changes

OPs

Description

support elementwise_min/max/floordiv/where op precision types for kunlun2

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 26, 2023
@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

zhupengyang
zhupengyang previously approved these changes Oct 27, 2023
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reinterpret_cast<const void*>(index.data<int>()),
byte_times * index.numel());
} else {
index_ptr = index.template data<int8_t>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要根据 index_type 分别用 index.data() 或 index.data<int64_t>()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@newway newway force-pushed the layoutLM branch 2 times, most recently from de5a411 to 46d4c6f Compare November 1, 2023 06:49
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong19860320 hong19860320 changed the title [xpu] bind some kernel in kunlun2; test=develop [XPU] Support elementwise_min/max/floordiv/where more precision types for kunlun2 Nov 2, 2023
@hong19860320 hong19860320 changed the title [XPU] Support elementwise_min/max/floordiv/where more precision types for kunlun2 [XPU] Support elementwise_min/max/floordiv/where more precision types for KL1 and KL2 Nov 2, 2023
@hong19860320 hong19860320 merged commit 32cf649 into PaddlePaddle:develop Nov 3, 2023
28 checks passed
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants