-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR]Migrate Conv2DTranspose into pir #58416
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
def runTest(self): | ||
place = base.CPUPlace() | ||
self._test_equivalence(place) | ||
|
||
if base.core.is_compiled_with_cuda(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在self._test_equivalence函数内会重新设置place为CPUPlace,所以这个case相当于跑了两次CPU测试。如果跑GPU测试的话在CI上会有精度问题,所以在这个PR中删除了GPU的测试代码。
self.check_output_with_place( | ||
place, | ||
atol=1e-5, | ||
check_dygraph=(not self.use_mkldnn), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉如果是mkldnn单测的话,这里是不是没有啥意义
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我是直接把父类的函数copy过来了~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
子类既然是单独去测mkldnn的,那copy过来的代码继续加check_dygraph=(not self.use_mkldnn)本身没啥意义,是不是应该默认就关闭check dygraph的检查呢,不然会对后边看到代码的人造成困扰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我单独提个pr修改一下,感谢~
PR types
Others
PR changes
Others
Description
[PIR]Migrate Conv2DTranspose into pir
涉及到两个相关单测的修改
Pcard-67164