Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR]Migrate SGD into pir #58391

Merged
merged 3 commits into from
Oct 31, 2023
Merged

[PIR]Migrate SGD into pir #58391

merged 3 commits into from
Oct 31, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Oct 25, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

[PIR]Migrate SGD into pir
之前日升对SGD进行过修改，在本PR中尝试打开SGD相关的单测：

  • 打开了单测中所有的继承自OpTest的单测
  • 对于单测文件中原有的继承自TestCase的单测，没有打开，因为原有单测中使用了很多paddle.static.nn下的接口，这类接口我们都没有适配
  • 新增了一个pir的SGD的单测

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Oct 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 25, 2023
YuanRisheng
YuanRisheng reviewed Oct 31, 2023
View reviewed changes
test/legacy_test/test_sgd_op.py
out1 = self.run_static()
with paddle.pir_utils.IrGuard():
out2 = self.run_static()
np.testing.assert_allclose(out1, out2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议将这个单测改为新IR和动态图的结果做比对，这样在旧IR退场后这个单测依然可以使用

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的 我单独提一个PR修改吧~

@0x45f 0x45f merged commit 25a0df4 into PaddlePaddle:develop Oct 31, 2023
@0x45f 0x45f deleted the pir-sgd branch October 31, 2023 06:28
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@0x45f @zeroRains
[PIR]Migrate SGD into pir (PaddlePaddle#58391)
a851178
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@0x45f
[PIR]Migrate SGD into pir (PaddlePaddle#58391)
4a6cfdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@changeyoung98 changeyoung98 changeyoung98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x45f @Aurelius84 @changeyoung98 @YuanRisheng