Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR]modify vjp interface gen for control_flow #58355

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

xiaoguoguo626807
Copy link
Contributor

PR types

others

PR changes

others

Description

pcard-67164
修改op_vjp 生成,使得反向算子使用vjp接口传入的前向算子输入和输出变量。

@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@changeyoung98 changeyoung98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 changed the title 【pir】modify vjp interface gen for control_flow [PIR]modify vjp interface gen for control_flow Oct 25, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build_args_str = ''
grad_idx = -1
for idx in range(len(bw_input_list)):
build_args_str += bw_input_list[idx] + ", "
bw_input_name = bw_input_list[idx]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在框架里对于forward和backward两个词的缩写一般是 fwd 和 bwd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个pr修复

@paddle-bot paddle-bot bot added the contributor External developers label Oct 25, 2023
@xiaoguoguo626807 xiaoguoguo626807 merged commit a4a59c4 into PaddlePaddle:develop Oct 26, 2023
28 checks passed
@xiaoguoguo626807 xiaoguoguo626807 deleted the call_vjp branch October 26, 2023 01:15
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* modify vjp interface

* modify vjp interface

* modify test

* modify test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants