Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.37、38】 Migrate paddle.cholesky/cholesky_solve into pir #58341

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Oct 24, 2023

PR types

Others

PR changes

APIs

Description

  • 新IR Python API适配升级 #58067
    No.37 No.38
    PIR API 推全升级
    paddle.cholesky 迁移升级至 pir,并更新单测 单测覆盖率:5/6
    paddle.cholesky_solve 迁移升级至 pir,并更新单测 单测覆盖率:6/7

problem:
test_cholesky_solve_op.py: static_pir
TypeError: The type of 'main_program' in paddle.static.program_guard must be <class 'paddle.base.libpaddle.pir.Program'>, but received <class 'paddle.base.framework.Program'>.

test_cholesky.py: static_pir
TypeError: The type of 'main_program' in paddle.static.program_guard must be <class 'paddle.base.libpaddle.pir.Program'>, but received <class 'paddle.base.framework.Program'>.

@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 24, 2023
@enkilee enkilee changed the title 【PIR API adaptor No.37/38】 Migrate paddle.cholesky/cholesky_solve into pir 【PIR API adaptor No.37、38】 Migrate paddle.cholesky/cholesky_solve into pir Oct 25, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f
Copy link
Contributor

0x45f commented Oct 25, 2023

pr描述中,是因为problem的问题导致有些单测case没有打开吗?具体是哪些单测case没有打开呢?

@enkilee
Copy link
Contributor Author

enkilee commented Oct 26, 2023

2个都是继承自 TestCase 的单测

@0x45f 0x45f merged commit e5942e8 into PaddlePaddle:develop Oct 26, 2023
28 checks passed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@enkilee enkilee deleted the pir-api-no-37-38 branch December 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants