【PIR API adaptor No.24-26】Migrate paddle.bitwise_not/bitwise_or/bitwise_xor into pir #58331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
Ligoml
changed the title
Ligoml
changed the title
Aurelius84
previously approved these changes
Oct 25, 2023
YuanRisheng
previously approved these changes
Oct 25, 2023
|
对于bitwise_not_/bitwise_or_/bitwise_xor_这几以 _ 结尾的api，是inplace的api，他们都被inplace_apis_in_dygraph_only装饰了，是动态图下的api，不需要进行适配，辛苦把这几个api下的修改代码修改回来吧~ |
|
收到 |
|
但我看 bitwise_and_ 也改了？所以我也改了。 |
0x45f
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
No.24 No.25 No.26
PIR API 推全升级
将
paddle.bitwise_not迁移升级至 pir，并更新单测，单测覆盖率：6/6将
paddle.bitwise_or迁移升级至 pir，并更新单测，单测覆盖率：8/8将
paddle.bitwise_xor迁移升级至 pir，并更新单测，单测覆盖率：8/8