Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the CMakeLists.txt of trainer/tests and gserver/tests #5830

Merged
merged 8 commits into from
Dec 4, 2017
Merged

simplify the CMakeLists.txt of trainer/tests and gserver/tests #5830

merged 8 commits into from
Dec 4, 2017

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Nov 22, 2017

fix #5829

set(PYTHON_PATH
${PADDLE_SOURCE_DIR}/paddle/.set_python_path.sh -d
${PADDLE_SOURCE_DIR}/python/:${PADDLE_SOURCE_DIR}/paddle/gserver/tests)
function(gserver_test2 TARGET)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename gserver_test2 to gserver_test_with_python?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 09fc307 into PaddlePaddle:develop Dec 4, 2017
@luotao1 luotao1 deleted the cmake branch December 4, 2017 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify the CMakeLists.txt of trainer/tests and gserver/tests
2 participants